-
Notifications
You must be signed in to change notification settings - Fork 43
👽 Support ecodev/graphql-upload v8 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00e934b to
5114346
Compare
I'm OK with introducing it for the v6, we too had problems with update graphqlite to v8. Let's retarget to |
5114346 to
46d7ee7
Compare
46d7ee7 to
dd181b8
Compare
Okay, I rebased on |
|
Do you know why there are no CI checks presented in the PR? |
I do not know, Edit: looks like it ran with the following error:
|
|
OK, now all is green. Approved. Please release v6, merge to master, and release v7 |
|
Released as https://github.com/thecodingmachine/graphqlite-bundle/releases/tag/v6.2.0, I pulled it to my local project, and it worked correctly (when uploading a file and when not uploading one too) |
Fixes #259
Note that there are two alternative implementations:
Note that the anonymous class declaration is rather verbose and would have been simplified by https://wiki.php.net/rfc/property-capture
DummyResponseWithRequestallowing us to extract the ecodev/graphql-upload psr7 request from the middleware chain to allow passing it in our previous symfony flow.@andrew-demb note that I would like this for the v6 of this package, how would you like to proceed?
=>see answer #268 (comment), basically tagrets
6.xthen port