Skip to content

Conversation

@homersimpsons
Copy link
Collaborator

@homersimpsons homersimpsons commented Dec 11, 2025

Fixes #259

Note that there are two alternative implementations:

  1. e9445ba which uses an anonymous type and requires response type juggling (between symfony and psr7).
    Note that the anonymous class declaration is rather verbose and would have been simplified by https://wiki.php.net/rfc/property-capture
  2. 5114346 (current) which uses concrete classes with a DummyResponseWithRequest allowing us to extract the ecodev/graphql-upload psr7 request from the middleware chain to allow passing it in our previous symfony flow.

@andrew-demb note that I would like this for the v6 of this package, how would you like to proceed?
=>see answer #268 (comment), basically tagrets 6.x then port

@homersimpsons homersimpsons force-pushed the fix/support-ecodev-graphql-upload-v8 branch 3 times, most recently from 00e934b to 5114346 Compare December 11, 2025 09:21
@andrew-demb
Copy link
Collaborator

@andrew-demb note that I would like this for the v6 of this package, how would you like to proceed?

I'm OK with introducing it for the v6, we too had problems with update graphqlite to v8.

Let's retarget to 6.x branch then.

@homersimpsons homersimpsons force-pushed the fix/support-ecodev-graphql-upload-v8 branch from 5114346 to 46d7ee7 Compare December 17, 2025 14:12
@homersimpsons homersimpsons force-pushed the fix/support-ecodev-graphql-upload-v8 branch from 46d7ee7 to dd181b8 Compare December 17, 2025 14:17
@homersimpsons homersimpsons changed the base branch from master to 6.x December 17, 2025 14:17
@homersimpsons
Copy link
Collaborator Author

@andrew-demb note that I would like this for the v6 of this package, how would you like to proceed?

I'm OK with introducing it for the v6, we too had problems with update graphqlite to v8.
Let's retarget to 6.x branch then.

Okay, I rebased on 6.x. Note that I had some minimal conflicts during cherry-pick (use function ... were in between classes, processRequest did not have an assert after it), so cherry-picking to master should observe some small, straightforward conflicts, I can handle the port to master once this get merged to 6.x.

@andrew-demb
Copy link
Collaborator

Do you know why there are no CI checks presented in the PR?
@homersimpsons

@homersimpsons
Copy link
Collaborator Author

homersimpsons commented Dec 17, 2025

Do you know why there are no CI checks presented in the PR? @homersimpsons

I do not know, .github/workflows/test.yaml file has the following configuration (that did not change for 4 years):

on:
    pull_request: ~
    push:
        branches:
            - master

Edit: looks like it ran with the following error:

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: v4.0.2. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

@andrew-demb
Copy link
Collaborator

OK, now all is green.

Approved. Please release v6, merge to master, and release v7

@homersimpsons homersimpsons merged commit a227d09 into 6.x Dec 17, 2025
1 check passed
@homersimpsons homersimpsons deleted the fix/support-ecodev-graphql-upload-v8 branch December 17, 2025 15:01
@homersimpsons
Copy link
Collaborator Author

homersimpsons commented Dec 17, 2025

Released as https://github.com/thecodingmachine/graphqlite-bundle/releases/tag/v6.2.0, I pulled it to my local project, and it worked correctly (when uploading a file and when not uploading one too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ecodev/graphql-upload v8

3 participants