fix: clamp text_standard grade levels to sensible bounds#217
Open
JohnGiorgi wants to merge 5 commits intotextstat:mainfrom
Open
fix: clamp text_standard grade levels to sensible bounds#217JohnGiorgi wants to merge 5 commits intotextstat:mainfrom
JohnGiorgi wants to merge 5 commits intotextstat:mainfrom
Conversation
Fixes textstat#205 The text_standard() method now clamps the output to educational grade bounds of 1-18 (kindergarten through graduate school). This prevents nonsensical outputs like "-1th and 0th grade" for very simple text or "25th and 26th grade" for very complex text. The clamping is applied before both float and string outputs.
Updates existing test expectations for empty string (now clamps to minimum grade level) and adds new test cases for very simple and very complex text to verify the bounds clamping behavior.
JohnGiorgi
commented
Jan 13, 2026
JohnGiorgi
commented
Jan 13, 2026
JohnGiorgi
commented
Jan 13, 2026
Member
|
@JohnGiorgi thanks for raising this! Is there anything you wanted to add, or can we mark it as ready for review? |
- Add VERY_SIMPLE_TEXT and VERY_COMPLEX_TEXT to tests/backend/resources.py - Update test_text_standard.py to import from resources instead of defining locally - Fix linting issues (blank lines, line length)
Author
|
@alxwrd I was just a bit unsure if my bounds were reasonable but otherwise this is ready for a look, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #205
Changes
This PR clamps the "readability-consensus" score computed by
textstat.text_standardto reasonable bounds:The clamping is applied before both
float_output=Trueandfloat_output=Falsecases.Testing
Rationale for bounds