Merged
Conversation
Member
|
@d-led thanks for finding and raising this! |
Member
|
Released as |
Contributor
Author
Superb, thanks likewise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gunning_fogfores, the call raises an exception due to the missing keysyllable_thresholdAnalysis
debugging reveals that the function might have been designed to work as:
but that's not how it works, and the function throws, even though the default config
enexists.Solution
If the logic is correct, here's the fix in this MR + the test to demonstrate. The logic is made somewhat more trivial.