Skip to content

fix(android): safer heartbeat body handling - #348

Open
wized2 wants to merge 1 commit into
textbee:mainfrom
wized2:fix/hb-f
Open

fix(android): safer heartbeat body handling#348
wized2 wants to merge 1 commit into
textbee:mainfrom
wized2:fix/hb-f

Conversation

@wized2

@wized2 wized2 commented Sep 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Avoid force-unwrap on response body.

Summary by CodeRabbit

  • Bug Fixes
    • Prevented potential crashes when a heartbeat response has no body.
    • Heartbeat processing now safely reports failure when the response body is unavailable.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

@wized2 is attempting to deploy a commit to the Nuver Labs Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: edd0379f-5243-4096-8d91-9b91cccb4a55

📥 Commits

Reviewing files that changed from the base of the PR and between daf0d2e and f28c3c5.

📒 Files selected for processing (1)
  • android/app/src/main/java/com/vernu/sms/helpers/HeartbeatHelper.kt

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The heartbeat sender now returns false when response.body() is null instead of throwing a null-pointer exception.

Changes

Heartbeat response safety

Layer / File(s) Summary
Safe heartbeat response handling
android/app/src/main/java/com/vernu/sms/helpers/HeartbeatHelper.kt		 sendHeartbeat uses an early false return when the heartbeat response body is null.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: vernu

Merge Risk: ⚪ Minimal · up to f28c3

Heartbeat failures continue to retry or reschedule without crashing, so this change is safe to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Android heartbeat body handling fix. It is concise and matches the main change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wized2