Skip to content

Conversation

@itsik-avidan
Copy link
Contributor

@itsik-avidan itsik-avidan commented May 5, 2021

What:
Changed the refs from the 'master' branch into 'main'
resolves #674

Why:
To be more compliment with updated web standards

How:
updated mainly the contribution guide and the validation file, kept 'master' branch available to be backward compatible as an intermediate phase

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e26acc0:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #675 (e26acc0) into master (1bbac04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #675   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          934       934           
  Branches       368       368           
=========================================
  Hits           934       934           
Impacted Files Coverage Δ
src/keyboard/getNextKeyDef.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbac04...e26acc0. Read the comment docs.

@ph-fritsche
Copy link
Member

I'm not sure about this. Basically the default branch can be named anything. So changing it doesn't really hurt.
On the other hand: Why change it at all as it is arbitrary and meaningless?
If you want to attribute any meaning, imho it should be renamed latest as it is our release branch to the latest channel.

@nickserv
Copy link
Member

nickserv commented Jul 18, 2021

So changing it doesn't really hurt.

We're already using main in most of our projects, so not renaming user-event's branch could cause confusion.

On the other hand: Why change it at all as it is arbitrary and meaningless?

The term master has a history in racism and is potentially offensive.

If you want to attribute any meaning, imho it should be renamed latest as it is our release branch to the latest channel.

While I personally like keeping default branches stable, commits in default branches are not necessarily published to npm (IIRC our chore commits aren't actually published until a commit after them needs to be published). Additionally, the git community (including GitHub's new repositories and Testing Library as a whole) is already moving to main, so I think it's best to be consistent. We'll keep the latest tag on npm because npm is not a version control system, so that's not directly related.

@ph-fritsche
Copy link
Member

The term master has a history in racism and is potentially offensive.

I'm aware of this. I just don't agree.
Everything might be connoted and be offensive in a different context. But it's a different context.

are not necessarily published to npm (IIRC our chore commits aren't actually published until a commit after them needs to be published).

You're absolutely correct. But different areas on the same channel aren't something unheard of.
If you have a latest-branch, a latest-testing and a latest-build that doesn't necessarily mean your latest-package will at all time refer to the same commit. One could fail or in the case of chore commits decide that it is not necessary to relay it further.

We're already using main in most of our projects, so not renaming user-event's branch could cause confusion. [...]
Additionally, [...] Testing Library as a whole is already moving to main, so I think it's best to be consistent.

👍 Good enough for me if you guys feel strongly about this.

@ph-fritsche ph-fritsche merged commit a31ecc9 into testing-library:master Jul 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 13.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate git repo to use "main" branch

3 participants