Skip to content

Add ability to expose both http and native ports for clickhouse (#257) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yakimka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ability to expose both http and native ports for clickhouse (#257) #261

yakimka wants to merge 1 commit into from
+15 −4

Conversation

@yakimka
Copy link
Contributor

@yakimka yakimka commented Oct 31, 2022 •
edited
Loading

Fixed #257

@yakimka yakimka changed the title Draft: Add ability to expose both http and native ports for clickhouse (#257) Add ability to expose both http and native ports for clickhouse (#257) Oct 31, 2022
@yakimka yakimka requested a review from tillahoffmann October 31, 2022 18:46
@tillahoffmann
Copy link
Contributor

tillahoffmann commented Feb 17, 2023

@yakimka, sorry for the slow follow up on this. Would you mind rebasing on master? I'm also planning a major-version release so we can squeeze in the breaking change of dropping the port argument. I'm breaking a bunch of other things in #296.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (472da35) to head (618b83d).
Report is 301 commits behind head on main.

Files Patch % Lines
testcontainers/clickhouse.py 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   85.93%   85.65%   -0.28%     
==========================================
  Files          28       28              
  Lines         782      788       +6     
  Branches       77       78       +1     
==========================================
+ Hits          672      675       +3     
- Misses         81       83       +2     
- Partials       29       30       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tillahoffmann tillahoffmann Awaiting requested review from tillahoffmann

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community-feat feature but its a community module so we wont bump tc core for it feat 📦 package: clickhouse

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clickhouse container exposing ports setup is strange

5 participants

@yakimka @tillahoffmann @codecov-commenter @alexanderankin