Skip to content

Investigate what to do about "localnpipe" on windows #415

@alexanderankin

Description

@alexanderankin

it has been some time. the urllib3/docker-py incompatibilities are fixed. the time of using named pipes on windows is here. the question is how to deal with them in this library. for now, i am suggesting a fix like:

class DockerContainer:
    # ...
    def get_container_host_ip(self) -> str:
        # ...
        # see https://github.com/testcontainers/testcontainers-python/issues/415
        if host == "localnpipe" and "Windows" == system():
            return "localhost"
        # ...

but it really should get investigated in the short term.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions