Allow to set Shared Memory size (shmSize) for GenericContainer - #957
Conversation
|
Thanks @fzakaria. Looks like CircleCI had an unrelated glitch downloading the gradle wrapper so I've restarted the build. |
|
Thanks @rnorth -- looks to have been resolved. |
|
I updated the PR to have shmSize be simply bytes instead of 'megabytes' to avoid mebibyte vs megabyte confusion. |
|
Looks like travis-ci had a flaky failure pulling an artifact -- could someone restart. |
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
I've restarted Travis and added some comments up for discussion.
|
Thanks for feedback @kiview -- I've addressed them with latest update.
|
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Great changes, thanks!
I found one more small thing in the Javadoc.
…ner.java Co-Authored-By: fzakaria <farid.m.zakaria@gmail.com>
|
Updated @kiview . |
Co-Authored-By: fzakaria <farid.m.zakaria@gmail.com>
|
@kiview What's next step to get this merged & published? |
|
Hey @fzakaria, sorry for letting this hanging, I think it's good to go. |
|
@bsideup made changes requested. |
|
Update on this ? Quite a lot of effort to get a helpful change in. |
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Hi @fzakaria,
as said before, thanks for the PR.
I can understand your frustration, but please keep in mind, that we are working on Testcontainers in our spare time. As such, there might be periods of time, were each of us can't invest the time we'd like to ideally invest into the project.
I have requested a tiny change (remove blank lines to reduce the diff) and then I'll merge directly.
…ner.java Co-Authored-By: fzakaria <farid.m.zakaria@gmail.com>
…ner.java Co-Authored-By: fzakaria <farid.m.zakaria@gmail.com>
|
@kiview thanks. |
|
Travis failure unrelated, restarted. |
|
@fzakaria merged, thanks a lot for the great PR as well as your patience 🙂 |
4 participants
Add the necessary code so that
shmSizecan be set on a GenericContainer.This is especially useful for when starting Oracle docker images because they need at least 1GB of shared memory space.
Fixes #952