Skip to content

Conversation

@mbaechler
Copy link
Contributor

Following #61 issue, I fixed an issue into docker-java docker-java/docker-java#457 and docker-java 2.2.0 contains it.

We just need testcontainers-java to depend on docker-java 2.2.0 to have this issue fixed.

@mbaechler mbaechler changed the title upgrade docker-java to 2.2.2 to fix unix socket support upgrade docker-java to 2.2.0 to fix unix socket support Feb 16, 2016
@rnorth
Copy link
Member

rnorth commented Feb 16, 2016

Great, thank you so much for this!

Please could you add yourself to the AUTHORS file and authors list in the root pom?

I'll merge and try and release during this week.
Thank you
Richard

On 16 Feb 2016, at 15:19, Matthieu Baechler notifications@github.com wrote:

Following #61 issue, I fixed an issue into docker-java docker-java/docker-java#457 and docker-java 2.2.0 contains it.

We just need testcontainers-java to depend on docker-java 2.2.0 to have this issue fixed.

You can view, comment on, or merge this pull request online at:

#67

Commit Summary

upgrade docker-java to 2.2.2 to fix unix socket support
File Changes

M core/pom.xml (4)
Patch Links:

https://github.com/testcontainers/testcontainers-java/pull/67.patch
https://github.com/testcontainers/testcontainers-java/pull/67.diff

Reply to this email directly or view it on GitHub.

@mbaechler
Copy link
Contributor Author

Ok, done.
There's a typo in my first commit message : it's not 2.2.2 but 2.2.0. can you fix it at merge time or can I push --force my PR ?

@rnorth rnorth merged commit b33c53e into testcontainers:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants