Skip to content

Add lang and version labels to containers - #6124

Merged
eddumelendez merged 7 commits into
mainfrom
ryuk_labels
Nov 7, 2022
Merged

Add lang and version labels to containers#6124
eddumelendez merged 7 commits into
mainfrom
ryuk_labels

Conversation

@eddumelendez

Copy link
Copy Markdown
Member

The following labels are added org.testcontainers.lang and
org.testcontainers.version. Those are good identifiers when debugging
and sharing logs.

The following labels are added `org.testcontainers.lang` and
`org.testcontainers.version`. Those are good identifiers when debugging
and sharing logs.
@eddumelendez
eddumelendez requested a review from a team November 4, 2022 17:30
@eddumelendez

Copy link
Copy Markdown
Member Author

This is an example of the output:

2022/11/04 17:22:41 Adding {"label":{"org.testcontainers.lang=java":true,"org.testcontainers.sessionId=ad33374e-ce55-4f13-9191-13f04bdffcb7":true,"org.testcontainers.version=1.17.6-SNAPSHOT":true,"org.testcontainers=true":true}}

@eddumelendez eddumelendez added this to the next milestone Nov 4, 2022
kiview
kiview previously approved these changes Nov 7, 2022
mdelapenya
mdelapenya previously approved these changes Nov 7, 2022
Comment thread core/src/main/java/org/testcontainers/utility/ResourceReaper.java Outdated
@eddumelendez
eddumelendez dismissed stale reviews from mdelapenya and kiview via 7f446b5 November 7, 2022 16:59
@eddumelendez eddumelendez changed the title Add lang and version labels to ryuk container Add lang and version labels to containers Nov 7, 2022
@eddumelendez
eddumelendez requested a review from bsideup November 7, 2022 17:00
bsideup
bsideup previously approved these changes Nov 7, 2022

@bsideup bsideup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with a couple of nits 👍

Comment thread core/src/main/java/org/testcontainers/DockerClientFactory.java Outdated
Comment thread core/src/main/java/org/testcontainers/DockerClientFactory.java Outdated
eddumelendez and others added 2 commits November 7, 2022 17:18
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez

Copy link
Copy Markdown
Member Author

good catch @bsideup! thanks!

@eddumelendez
eddumelendez merged commit f66aee1 into main Nov 7, 2022
@eddumelendez
eddumelendez deleted the ryuk_labels branch November 7, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants