Skip to content

Force Jackson version - #3602

Merged
bsideup merged 2 commits into
masterfrom
force_jackson_version
Feb 6, 2021
Merged

Force Jackson version#3602
bsideup merged 2 commits into
masterfrom
force_jackson_version

Conversation

@bsideup

@bsideup bsideup commented Dec 14, 2020

Copy link
Copy Markdown
Member

It seems that #3579 didn't work :(

See the following Slack thread:
https://testcontainers.slack.com/archives/C1SUBPZK6/p1607967117450100

@bsideup bsideup added dependencies Pull requests that update a dependency file java labels Dec 14, 2020
@bsideup bsideup added this to the next milestone Dec 14, 2020
@snemarch

Copy link
Copy Markdown

For people who might find this bug, and aren't on Slack: the (shaded) org.testcontainers.shaded.com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector has references to (non-shaded) com.fasterxml.jackson.annotation.*.

A band-aid for our usecase was to add jackson-annotations:2.9.0 on the test classpath – TestContainers 1.15.1 includes jackson-databind:2.8.8, but the JacksonAnnotationIntrospector references the JsonMerge annotation which wasn't added before 2.9.0 🤔

@bsideup

bsideup commented Dec 14, 2020

Copy link
Copy Markdown
Member Author

The non-shaded reference isn't a problem, actually.

The actual issue comes from the fact that Jackson Databind 2.9+ does not work with annotations 2.8 and requires them to be 2.9 or higher.

@bsideup
bsideup merged commit 864df2d into master Feb 6, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the force_jackson_version branch February 6, 2021 14:24
@bsideup bsideup mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants