Skip to content

Postgresql 9.6.8 -> 9.6.12 - #1350

Merged
rnorth merged 1 commit into
testcontainers:masterfrom
sullis:postgresql-9.6.12
Apr 14, 2019
Merged

Postgresql 9.6.8 -> 9.6.12#1350
rnorth merged 1 commit into
testcontainers:masterfrom
sullis:postgresql-9.6.12

Conversation

@sullis

@sullis sullis commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@sullis

sullis commented Apr 2, 2019

Copy link
Copy Markdown
Contributor Author

LGTM

@rnorth

rnorth commented Apr 8, 2019

Copy link
Copy Markdown
Member

Hi @sullis
Thanks for the PR and sorry for not reviewing previously. Ordinarily we don't try to keep base images up with the latest. It's quite normal (and frankly, desirable) for people to specify whichever version of the container image they want. e.g. new PostgreSQLContainer("postgres:9.6.12").

This way tests can remain nice and stable, with Testcontainers' potentially arbitrary choice of images not being a destabilizing factor.

As a patch version update I'd not expect breaking changes, so we can accept this PR. However, I just want you to be aware that there are other options available to you.
Thanks
Richard

@rnorth
rnorth merged commit 92fc7fa into testcontainers:master Apr 14, 2019
@rnorth rnorth added this to the next milestone Apr 14, 2019
@rnorth

rnorth commented Apr 16, 2019

Copy link
Copy Markdown
Member

Released in 1.11.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants