Skip to content

Remove SLF4J Profiler - #1002

Merged
rnorth merged 4 commits into
masterfrom
remove-profiler
Dec 8, 2018
Merged

Remove SLF4J Profiler#1002
rnorth merged 4 commits into
masterfrom
remove-profiler

Conversation

@rnorth

@rnorth rnorth commented Dec 2, 2018

Copy link
Copy Markdown
Member

This was useful while we were working to optimise performance, but now I feel it's just clutter and can be safely removed.

@rnorth
rnorth requested review from bsideup and kiview as code owners December 2, 2018 22:00

@kiview kiview left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is great, thanks 😄

@bsideup

bsideup commented Dec 5, 2018

Copy link
Copy Markdown
Member

@rnorth we should remove it from build.gradle as well :)

@rnorth

rnorth commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

Ahah. It’s been so long since I added it that I may have forgotten there was an extra dependency!

Sent with GitHawk

@rnorth
rnorth merged commit dce6264 into master Dec 8, 2018
@delete-merged-branch
delete-merged-branch Bot deleted the remove-profiler branch December 8, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants