Repository navigation
Conversation
When `alphabetize` was set to `false`, the early return on line 258 skipped the `refToTokenID()` conversion, causing token IDs to remain in JSON Pointer format (#/size/sm) instead of dot notation (size.sm). This change ensures `refToTokenID()` always runs on token IDs while only conditionally sorting them. Fixes terrazzoapp#734
|
Adds two test cases: - Verifies token IDs use dot notation when alphabetize is false (the bug from terrazzoapp#734 - IDs were using JSON Pointer format) - Verifies token IDs use dot notation and are sorted when alphabetize is true
drwpow
approved these changes
Apr 24, 2026
drwpow
left a comment
drwpow
left a comment
Collaborator
There was a problem hiding this comment.
Amazing, thank you! We should release this.
2 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #734
When
alphabetizeis set tofalse, the early return inprocess.ts(line 258) skipped therefToTokenID()conversion, causing token IDs to remain in JSON Pointer format (#/size/sm) instead of dot notation (size.sm).This change ensures
refToTokenID()always runs on token IDs while only conditionally sorting them, so token ID format is consistent regardless of thealphabetizesetting.Changes
alphabetize === falserefToTokenID()conversion to normalize token IDsalphaComparatoronly whenalphabetize !== falsealphabetize !== falseTest plan