feat(variables): Add variable types to default_origin, cache_behavior, ordered_cache_behavior. #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcube
commented
Jul 31, 2025
Comment on lines
-84
to
-95
| domain_name = origin.value.domain_name | ||
| origin_id = lookup(origin.value, "origin_id", origin.key) | ||
| origin_path = lookup(origin.value, "origin_path", "") | ||
| connection_attempts = lookup(origin.value, "connection_attempts", null) | ||
| connection_timeout = lookup(origin.value, "connection_timeout", null) | ||
| origin_access_control_id = lookup(origin.value, "origin_access_control_id", lookup(lookup(aws_cloudfront_origin_access_control.this, lookup(origin.value, "origin_access_control", ""), {}), "id", null)) | ||
|
|
||
| dynamic "s3_origin_config" { | ||
| for_each = length(keys(lookup(origin.value, "s3_origin_config", {}))) == 0 ? [] : [lookup(origin.value, "s3_origin_config", {})] | ||
|
|
||
| content { | ||
| origin_access_identity = lookup(s3_origin_config.value, "cloudfront_access_identity_path", lookup(lookup(aws_cloudfront_origin_access_identity.this, lookup(s3_origin_config.value, "origin_access_identity", ""), {}), "cloudfront_access_identity_path", null)) |
There was a problem hiding this comment.
all origin params have been re-ordered to match provider documentation and remove opinionation.
kevcube
changed the title
kevcube
changed the title
|
note: there's more |
kevcube
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Not stale On Sep 26, 2025, at 08:08, github-actions[bot] ***@***.***> wrote:github-actions[bot] left a comment (terraform-aws-modules/terraform-aws-cloudfront#167)
This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Not stale @antonbabenko can you please take a look
… On Oct 27, 2025, at 08:09, github-actions[bot] ***@***.***> wrote:
github-actions[bot]
left a comment
(terraform-aws-modules/terraform-aws-cloudfront#167)
<#167 (comment)>
This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days
—
Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFPABW6IKWN63IDPNRE2733ZVPBZAVCNFSM6AAAAACCZREQFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINBZGA2DANJWGA>.
You are receiving this because you authored the thread.
|
|
@bryantbiggs I designed this to be not a breaking change, I believe this can be cleanly upgraded/rolled back. |
|
I am unable to remove the stale label :0 |
you are changing defaults which is a breaking change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds variable typings to
default_origincache_behaviorRemoves lots of lookup() and try() calls because variables will now have default values of null and won't error.