Skip to content

Set cursor-pointer default correctly#7053

Merged
GabrielBianconi merged 2 commits intomainfrom
gb/cursor-pointer
Mar 24, 2026
Merged

Set cursor-pointer default correctly#7053
GabrielBianconi merged 2 commits intomainfrom
gb/cursor-pointer

Conversation

@GabrielBianconi
Copy link
Copy Markdown
Member

@GabrielBianconi GabrielBianconi commented Mar 24, 2026

Note

Low Risk
Low risk styling-only change that centralizes the cursor-pointer class in the shared button variant styles; could slightly affect cursor behavior for any consumers relying on overriding it.

Overview
Ensures Button always gets cursor-pointer via the base buttonVariants styles rather than injecting it separately in the component.

This simplifies the className composition to rely solely on buttonVariants({ variant, size, className }), making cursor behavior consistent across all buttonVariants consumers.

Written by Cursor Bugbot for commit dc11d9e. This will update automatically on new commits. Configure here.

virajmehta
virajmehta previously approved these changes Mar 24, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Removing cn() wrapper breaks Tailwind class override resolution
    • Restored the cn(...) wrapper around buttonVariants(...) in Button so Tailwind class conflicts are merged and consumer className overrides work reliably again.

Create PR

Or push these changes by commenting:

@cursor push 0ac211f831
Preview (0ac211f831)
diff --git a/ui/app/components/ui/button.tsx b/ui/app/components/ui/button.tsx
--- a/ui/app/components/ui/button.tsx
+++ b/ui/app/components/ui/button.tsx
@@ -87,7 +87,7 @@
 
   return (
     <Comp
-      className={buttonVariants({ variant, size, className })}
+      className={cn(buttonVariants({ variant, size, className }))}
       disabled={isDisabled}
       {...props}
     >

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57dcaa584f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@GabrielBianconi GabrielBianconi added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit 683f594 Mar 24, 2026
74 checks passed
@GabrielBianconi GabrielBianconi deleted the gb/cursor-pointer branch March 24, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants