Skip to content

Refactor workflow evaluation project page data fetching#6184

Open
simeonlee wants to merge 1 commit intomainfrom
simeonlee/wf-eval-project-refactor
Open

Refactor workflow evaluation project page data fetching#6184
simeonlee wants to merge 1 commit intomainfrom
simeonlee/wf-eval-project-refactor

Conversation

@simeonlee
Copy link
Member

@simeonlee simeonlee commented Feb 5, 2026

Summary

  • Extract fetchResultsData helper to consolidate data fetching logic
  • Extract ResultsContent component for results table and pagination
  • Remove duplicate getTensorZeroClient() call
  • Use useSearchParams instead of window.location.search
  • Pure refactor — no behavior changes, prepares for streaming in a follow-up PR

Test plan

  • Verify project page works identically to before
  • Verify run selection and comparison works
  • Verify pagination works
  • Run e2e tests: pnpm test-e2e

Note

Low Risk
Pure refactor of a single route: behavior should be unchanged, with main risk limited to subtle pagination/query-param regressions.

Overview
Consolidates the workflow evaluation project page loader’s parallel data fetching into a shared fetchResultsData helper (single getTensorZeroClient() instance), keeping the returned shape the same.

Extracts the results table + pagination into ResultsContent and updates pagination to use react-router’s useSearchParams (instead of window.location.search) when navigating between offsets.

Written by Cursor Bugbot for commit ecb3a89. This will update automatically on new commits. Configure here.

Extract fetchResultsData helper and ResultsContent component to prepare
for streaming. Use useSearchParams instead of window.location.search for
pagination. Remove duplicate getTensorZeroClient() call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant