Add streaming to workflow evaluation run detail page#6183
Open
Add streaming to workflow evaluation run detail page#6183
Conversation
Defer all data loading behind a single Suspense boundary. The page header shows the run ID from route params immediately while data loads.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| description={message} | ||
| /> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Duplicated error message extraction logic
Low Severity
The ContentError function manually extracts error messages using isRouteErrorResponse and instanceof Error checks. This duplicates the existing getErrorMessage utility from ~/components/ui/error/ErrorContentPrimitives which provides the same functionality. Using getErrorMessage({ error, fallback: "Failed to load workflow evaluation run" }) would be cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchRunDatahelper with all data fetching logicuseSearchParamsinstead ofwindow.location.search!=to!==for strict equalityTest plan
pnpm test-e2eNote
Low Risk
UI-only refactor to async rendering and pagination URL handling; main risk is regressions in loading/error states and offset navigation.
Overview
Streams the workflow evaluation run detail page by returning a deferred
runDatapromise from the loader and rendering it viaSuspense/Await, so the run ID header shows immediately while data loads.Extracts fetching into
fetchRunDataand adds dedicated skeleton and error states (with consistent header +SectionErrorNotice). Pagination now usesuseSearchParamsinstead ofwindow.location.search, and a strict equality check replaces!=with!==.Written by Cursor Bugbot for commit dba7819. This will update automatically on new commits. Configure here.