Skip to content

Fix variant BasicInfo rendering '0' when numeric fields are zero #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simeonlee wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −26
Open

Fix variant BasicInfo rendering '0' when numeric fields are zero #6128

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6110570
Fix variant BasicInfo rendering "0" when numeric fields are zero
simeonlee Feb 4, 2026
a4250fb
Merge branch 'main' into simeonlee/fix-variant-basicinfo-zero-render
simeonlee Feb 4, 2026
7901f42
Use loose equality (!= null) for variant config null checks
simeonlee Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions ui/app/routes/observability/functions/$function_name/variants/VariantBasicInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function BasicInfo({
</BasicInfoItemContent>
</BasicInfoItem>

{variantConfig.temperature && (
{variantConfig.temperature != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Temperature</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -73,7 +73,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{variantConfig.top_p && (
{variantConfig.top_p != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Top P</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -82,7 +82,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{variantConfig.max_tokens && (
{variantConfig.max_tokens != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Max Tokens</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -91,7 +91,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{variantConfig.presence_penalty && (
{variantConfig.presence_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Presence Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -100,7 +100,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{variantConfig.frequency_penalty && (
{variantConfig.frequency_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Frequency Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -109,7 +109,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{variantConfig.seed && (
{variantConfig.seed != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Seed</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -133,7 +133,7 @@ export default function BasicInfo({
</BasicInfoItemContent>
</BasicInfoItem>

{config.evaluator.temperature && (
{config.evaluator.temperature != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Temperature</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -142,7 +142,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.evaluator.top_p && (
{config.evaluator.top_p != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Top P</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -151,7 +151,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.evaluator.max_tokens && (
{config.evaluator.max_tokens != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Max Tokens</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -160,7 +160,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.evaluator.presence_penalty && (
{config.evaluator.presence_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Presence Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -171,7 +171,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.evaluator.frequency_penalty && (
{config.evaluator.frequency_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Frequency Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -182,7 +182,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.evaluator.seed && (
{config.evaluator.seed != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Seed</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand Down Expand Up @@ -245,15 +245,15 @@ export default function BasicInfo({
<BasicInfoItemContent>
<Chip
label={
config.max_distance !== null
config.max_distance != null
? config.max_distance.toString()
: "-"
}
/>
</BasicInfoItemContent>
</BasicInfoItem>

{config.temperature && (
{config.temperature != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Temperature</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -262,7 +262,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.top_p && (
{config.top_p != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Top P</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -271,7 +271,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.max_tokens && (
{config.max_tokens != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Max Tokens</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -280,7 +280,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.presence_penalty && (
{config.presence_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Presence Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -289,7 +289,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.frequency_penalty && (
{config.frequency_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Frequency Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -298,7 +298,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.seed && (
{config.seed != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Seed</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -323,7 +323,7 @@ export default function BasicInfo({
</BasicInfoItemContent>
</BasicInfoItem>

{config.fuser.temperature && (
{config.fuser.temperature != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Temperature</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -332,7 +332,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.fuser.top_p && (
{config.fuser.top_p != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Top P</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -341,7 +341,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.fuser.max_tokens && (
{config.fuser.max_tokens != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Max Tokens</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -350,7 +350,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.fuser.presence_penalty && (
{config.fuser.presence_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Presence Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -359,7 +359,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.fuser.frequency_penalty && (
{config.fuser.frequency_penalty != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Frequency Penalty</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand All @@ -368,7 +368,7 @@ export default function BasicInfo({
</BasicInfoItem>
)}

{config.fuser.seed && (
{config.fuser.seed != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Seed</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand Down Expand Up @@ -397,7 +397,7 @@ export default function BasicInfo({
})()}

{/* Weight */}
{variantConfig.weight !== null && (
{variantConfig.weight != null && (
<BasicInfoItem>
<BasicInfoItemTitle>Weight</BasicInfoItemTitle>
<BasicInfoItemContent>
Expand Down
Loading