Split workflow eval run detail into independent streaming sections#6091
Open
simeonlee wants to merge 2 commits intosimeonlee/workflow-eval-streamingfrom
Open
Split workflow eval run detail into independent streaming sections#6091simeonlee wants to merge 2 commits intosimeonlee/workflow-eval-streamingfrom
simeonlee wants to merge 2 commits intosimeonlee/workflow-eval-streamingfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| title="Error loading episodes" | ||
| description={message} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
Duplicate error handling replicates existing utility component
Medium Severity
BasicInfoError and EpisodesError duplicate the error handling logic that already exists in SectionAsyncErrorState from ~/components/ui/error/ErrorContentPrimitives.tsx. Both use identical patterns: useAsyncError(), checking isRouteErrorResponse(error) and error instanceof Error, then rendering SectionErrorNotice. The only difference is the title/message strings.
…low-eval-run-detail-split
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/workflow-evaluations/runs/$run_iddata fetching into two independent promisesbasicInfoData: run metadata + episode count (for header/BasicInfo)episodesData: episodes + statistics + count (for table/pagination)Changes
fetchBasicInfoData: fetches run info and countfetchEpisodesData: fetches episodes, statistics, and count (duplicated for pagination independence)<Suspense>boundaries for each sectionrun_idimmediately (from URL params)Stacked on #6088
Note
Medium Risk
Moderate risk because it changes the route loader’s data-fetching shape and streaming boundaries, which can affect rendering/error states and pagination behavior, though it’s confined to a single UI route.
Overview
Splits the
/workflow-evaluations/runs/$run_idroute into two independently streamed loader promises:basicInfoData(run metadata + episode count) andepisodesData(episodes + statistics + count for pagination).Moves
PageHeaderto render immediately from the URLrun_id, and adds separateSuspense/Awaitboundaries with dedicated skeletons and error notices so the basic info can appear while the episodes table continues loading.Written by Cursor Bugbot for commit 12aadf2. This will update automatically on new commits. Configure here.