Remove last usages of 'Error::new_with_err_logging' #4420
+40
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now produce a `DelayedError` from the clickhouse client code. This error gets suppressed in 'get_all_migration_records', and immediately logged everywhere else
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error handling in ClickHouse queries by replacing the new_with_err_logging method and run_query_synchronous_with_err_logging function with a new DelayedError type that provides more explicit control over when errors are logged.
Key changes:
- Removed
Error::new_with_err_loggingmethod in favor of usingDelayedError - Renamed
run_query_synchronous_with_err_loggingtorun_query_synchronous_delayed_erracross all ClickHouse client implementations - Updated the migration manager to use the new delayed error handling approach
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tensorzero-core/src/error/mod.rs | Removed the new_with_err_logging method from the Error type |
| tensorzero-core/src/db/clickhouse/mod.rs | Updated method signature to return DelayedError instead of Error |
| tensorzero-core/src/db/clickhouse/migration_manager/mod.rs | Updated to use new delayed error method and call suppress_logging_of_error_message() |
| tensorzero-core/src/db/clickhouse/clickhouse_client/production_clickhouse_client.rs | Replaced error logging parameter with DelayedError return type and explicit .log() calls |
| tensorzero-core/src/db/clickhouse/clickhouse_client/mod.rs | Updated trait definition and mock to use DelayedError |
| tensorzero-core/src/db/clickhouse/clickhouse_client/fake_clickhouse_client.rs | Updated implementation to return DelayedError |
| tensorzero-core/src/db/clickhouse/clickhouse_client/disabled_clickhouse_client.rs | Updated implementation to return DelayedError |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aaron1011
added
the
force-add-to-merge-queue
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aaron1011
removed
the
force-add-to-merge-queue
virajmehta
approved these changes
Nov 5, 2025
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now produce a
DelayedErrorfrom the clickhouse client code. This error gets suppressed in 'get_all_migration_records', and immediately logged everywhere else