Merged
Conversation
…viraj/experimentation-config
Two constraint bugs: - For the simplex constraint, had 1s everywhere instead of just at indices corresponding to the weights - Signs were backwards in the SOCP constraints
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
Minor copy/formatting changes |
GabrielBianconi
previously approved these changes
Oct 27, 2025
amishler
previously approved these changes
Oct 27, 2025
virajmehta
dismissed stale reviews from amishler and GabrielBianconi
via
de0a4af
…viraj/bandits-ui-mean-inference
amishler
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly done by @amishler
Adds a chart that shows the mean and confidence sequences for arms in a bandit problem.
Refactor of existing charts:
useTimeGranularityParamthat allows us to avoid a lot of prop drilling in all the places we have time granularities that use URL state.There is an outstanding bug in the query + chart logic where some timeseries that should be computing cumulative statistics can be sparse if there is no new data in the time series for the window that we are querying over. @amishler has opened an issue for this I believe, and will fix next week.
Important
Add mean and feedback count charts for bandits UI, refactor existing charts, and introduce a hook for managing time granularity parameters.
FeedbackMeansTimeseriesandFeedbackCountsTimeseriescomponents for displaying mean and feedback count charts.FeedbackSamplesTimeseriesto separate mean and count data.useTimeGranularityParamhook to manage time granularity in URL state.chart.ts.FunctionExperimentation.tsxfor switching between variant weights, estimated performance, and feedback count.PieChart.tsxdescription and title for clarity.computeTrackAndStopOptimalProbabilitiesto handle track_and_stop experimentation.route.tsx.README.md.app.py.This description was created by
for de0a4af. You can customize this summary. It will automatically update as commits are pushed.