Conversation
…viraj/experimentation-config
Two constraint bugs: - For the simplex constraint, had 1s everywhere instead of just at indices corresponding to the weights - Signs were backwards in the SOCP constraints
Member
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
virajmehta
requested changes
Oct 22, 2025
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
…o into alan/bandits-viz-ui
This was referenced Oct 22, 2025
virajmehta
reviewed
Oct 22, 2025
ui/app/components/function/variant/FeedbackSamplesTimeseries.tsx
Outdated
Show resolved
Hide resolved
…o into alan/bandits-viz-ui
virajmehta
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add UI components and backend logic for bandit experimentation, including feedback timeseries and optimal probability calculations.
FeedbackSamplesTimeseriescomponent inFeedbackSamplesTimeseries.tsxto display cumulative feedback counts over time.ExperimentationPieChartinPieChart.tsxto usememofor optimization.TimeGranularitySelectorinTimeGranularitySelector.tsxfor selecting time granularity.computeTrackAndStopOptimalProbabilitiesinexperimentation.server.tsfor calculating optimal sampling probabilities.FunctionExperimentation.tsxto use optimal probabilities fortrack_and_stopexperimentation.route.tsxto fetch feedback timeseries and compute optimal probabilities.jaro_winkler_similarity_feedback.jsonlto fixtures and updatecheck-fixtures.shandload_fixtures.shto include it.integration.test.tsto include environment variableTENSORZERO_POSTGRES_URLfor tests.This description was created by
for bca637d. You can customize this summary. It will automatically update as commits are pushed.