Skip to content

Create node version of estimate_optimal_probabilities for UI#4016

Merged
virajmehta merged 169 commits intomainfrom
alan/bandits-expose-sampling-probs-to-node
Oct 20, 2025
Merged

Create node version of estimate_optimal_probabilities for UI#4016
virajmehta merged 169 commits intomainfrom
alan/bandits-expose-sampling-probs-to-node

Conversation

@amishler
Copy link
Member

@amishler amishler commented Oct 17, 2025

Important

Adds estimateTrackAndStopOptimalProbabilities function to compute optimal sampling probabilities for bandit experiments, with TypeScript types and integration tests.

  • Functionality:
    • Adds estimateTrackAndStopOptimalProbabilities function in lib/index.ts to compute optimal sampling probabilities for bandit experiments using SOCP.
    • Integrates with Rust core function estimate_track_and_stop_optimal_probabilities in src/lib.rs.
  • TypeScript Types:
    • Adds EstimateTrackAndStopOptimalProbabilitiesParams in bindings/EstimateTrackAndStopOptimalProbabilitiesParams.ts.
    • Adds FeedbackByVariant in bindings/FeedbackByVariant.ts.
    • Adds GetFeedbackByVariantParams in bindings/GetFeedbackByVariantParams.ts.
  • Database Client:
    • Adds getFeedbackByVariant method in src/database.rs and lib/index.ts.
  • Tests:
    • Adds integration tests in tests/integration.test.ts for estimateTrackAndStopOptimalProbabilities and getFeedbackByVariant.

This description was created by Ellipsis for 9aa8161. You can customize this summary. It will automatically update as commits are pushed.

virajmehta and others added 30 commits September 26, 2025 11:23
Two constraint bugs:
- For the simplex constraint, had 1s everywhere instead of just at indices corresponding to the weights
- Signs were backwards in the SOCP constraints
@amishler amishler marked this pull request as ready for review October 20, 2025 15:15
Copy link
Member

@virajmehta virajmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments for renaming

@amishler
Copy link
Member Author

amishler commented Oct 20, 2025

Completed renaming

@amishler amishler closed this Oct 20, 2025
@amishler amishler reopened this Oct 20, 2025
@virajmehta virajmehta added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit ddb59c4 Oct 20, 2025
40 of 60 checks passed
@virajmehta virajmehta deleted the alan/bandits-expose-sampling-probs-to-node branch October 20, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants