Skip to content

DOC: formats momentum calculation for web #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmlarsen merged 2 commits into from
May 15, 2017
Merged

DOC: formats momentum calculation for web #9802

rmlarsen merged 2 commits into from
May 15, 2017

Conversation

@stsievert
Copy link
Contributor

@stsievert stsievert commented May 9, 2017

No description provided.

HuaizhengZhang and others added 2 commits May 3, 2017 20:37
@HuaizhengZhang
Add input function for training and testing (tensorflow#9617)
10ec24a 
* Add input function for training and testing

Estimator is decoupled from Scikit Learn interface by moving into separate class SKCompat. Arguments x, y and batch_size are only available in the SKCompat class, Estimator will only accept input_fn

* remove extra comma
@stsievert
DOC: format documentation for momentum calculation
48ea3f5
@tensorflow-jenkins
Copy link
Collaborator

tensorflow-jenkins commented May 9, 2017

Can one of the admins verify this patch?

@benoitsteiner benoitsteiner self-assigned this May 10, 2017
@benoitsteiner
Copy link
Contributor

benoitsteiner commented May 10, 2017

Jenkins, test this please.

1 similar comment
@benoitsteiner
Copy link
Contributor

benoitsteiner commented May 10, 2017

Jenkins, test this please.

@yifeif
Copy link
Contributor

yifeif commented May 10, 2017

Is this change intended for 1.1 branch? We don't usually accept changes to released branches. Could you make the change in master branch instead?

@stsievert stsievert changed the base branch from r1.1 to master May 10, 2017 21:22
@stsievert
Copy link
Contributor Author

stsievert commented May 10, 2017

Changed.

@googlebot
Copy link

googlebot commented May 10, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@stsievert
Copy link
Contributor Author

stsievert commented May 10, 2017

Yes, I'm okay with this PR being merged into master regardless of any other commits authored by others.

@yifeif
Copy link
Contributor

yifeif commented May 10, 2017

@tensorflow-jenkins test this please

@tensorflow-jenkins
Copy link
Collaborator

tensorflow-jenkins commented May 11, 2017

Can one of the admins verify this patch?

@rmlarsen
Copy link
Member

rmlarsen commented May 15, 2017

@tensorflow-jenkins test this please

@rmlarsen rmlarsen merged commit 237fced into tensorflow:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benoitsteiner benoitsteiner benoitsteiner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benoitsteiner benoitsteiner

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stsievert @tensorflow-jenkins @benoitsteiner @yifeif @googlebot @rmlarsen @HuaizhengZhang