Backport Windows builds into 2.18 for 2.18.1#88848
Merged
MichaelHudgins merged 7 commits intotensorflow:r2.18from Mar 7, 2025
Merged
Backport Windows builds into 2.18 for 2.18.1#88848MichaelHudgins merged 7 commits intotensorflow:r2.18from
MichaelHudgins merged 7 commits intotensorflow:r2.18from
Conversation
`set -u` (does not allow unbound variables) has been removed from all scripts. This is due to Docker on Windows treating variables in an env file, set to an empty value (`MY_VAR=`), as unbound variables. Consequently, these variables, even though they are "set", do not make it into the Docker container at all, and various checks for those variables fail outright. PiperOrigin-RevId: 713717958 (cherry picked from commit fa3b3c1)
PiperOrigin-RevId: 718920772 (cherry picked from commit 82ba59a)
…r upload. Temporary workaround. PiperOrigin-RevId: 719027529 (cherry picked from commit 7513f77)
PiperOrigin-RevId: 719389902 (cherry picked from commit 9ab2fee)
PiperOrigin-RevId: 720176067 (cherry picked from commit 768059f)
Currently only needed for Windows, since the same wheel is uploaded to both tensorflow_cpu, and tensorflow PyPi repos, but different names/metadata are needed. PiperOrigin-RevId: 720313792 (cherry picked from commit a93dc78)
PiperOrigin-RevId: 720753829 (cherry picked from commit 6ba7e4e)
MichaelHudgins
approved these changes
Mar 7, 2025
Collaborator
MichaelHudgins
left a comment
MichaelHudgins
left a comment
There was a problem hiding this comment.
Needed to provide 2.18.1 wheels for windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is being backported because Windows build jobs were added after 2.18, whereas 2.18 wheels were built and uploaded by Intel. Intel is no longer in charge of building any wheels, so this backport is necessary to be able to provide 2.18.1 wheels for Windows.