Cherrypick for tf-profiler fix #73658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shall fix the profiler trace viewer cache file generation. PiperOrigin-RevId: 659614772
belitskiy
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why cherrypick this:
Trace Viewer as a critical tool in tf-profiler is broken starting tensorflow 2.17 (working in 2.16.2) due to a change in cache file access. We need to cherrypick the fix into stable tensorflow versions to unblock external profiler users who develops models and debugging the performance with tf-profiler.
What this fixes:
Fix the profiler trace viewer cache file generation, and reenable trace viewer usage in the profiling tool.
PiperOrigin-RevId: 659614772