PR #10626: [XLA:CPU][oneDNN] Add a BF16 pattern for Softmax #63881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_616787847
branch
2 times, most recently
from
1635d3e to
25e34a7
Compare
Imported from GitHub PR openxla/xla#10626 This PR: 1. Adds a pattern for BF16 softmax. 2. Adds a test to verify rewrite and execution result. 3. Skips BF16 matmul / softmax tests on machines that do not support BF16 Copybara import of the project: -- f0370a18eed1f2b47d8dc15470b970029726b0e8 by Akhil Goel <akhil.goel@intel.com>: Add Softmax BF16 pattern and test -- 62af424e4e74ddb7f64584aa3b05be761db956dc by Akhil Goel <akhil.goel@intel.com>: Declare convert_instr identifier -- d030100ea87923582aa64cdcf0fac1464051288c by Akhil Goel <akhil.goel@intel.com>: Fix formatting Merging this change closes #10626 PiperOrigin-RevId: 617477998
copybara-service
bot
force-pushed
the
test_616787847
branch
from
25e34a7 to
cecebc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10626: [XLA:CPU][oneDNN] Add a BF16 pattern for Softmax
Imported from GitHub PR openxla/xla#10626
This PR:
Copybara import of the project:
--
f0370a18eed1f2b47d8dc15470b970029726b0e8 by Akhil Goel akhil.goel@intel.com:
Add Softmax BF16 pattern and test
--
62af424e4e74ddb7f64584aa3b05be761db956dc by Akhil Goel akhil.goel@intel.com:
Declare convert_instr identifier
--
d030100ea87923582aa64cdcf0fac1464051288c by Akhil Goel akhil.goel@intel.com:
Fix formatting
Merging this change closes #10626
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10626 from Intel-tensorflow:akhil/bf16_softmax d030100ea87923582aa64cdcf0fac1464051288c