Skip to content

Conversation

@yongtang
Copy link
Member

This PR fixes the issue raised in #46888 where tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large.

This PR fixes #46888.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

…t_ids is large

This PR fixes the issue raised in 46888 where
tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large.

This PR fixes 46888.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 28, 2021
@google-cla google-cla bot added the cla: yes label Aug 28, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 28, 2021
@gbaned gbaned self-assigned this Aug 30, 2021
@gbaned gbaned added comp:ops OPs related issues prtype:bugfix PR to fix a bug labels Aug 30, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 30, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Sep 2, 2021
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Sep 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 3, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 1, 2021
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Oct 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 27, 2021
@copybara-service copybara-service bot merged commit e9c81c1 into tensorflow:master Oct 28, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 28, 2021
mihaimaruseac added a commit that referenced this pull request Oct 28, 2021
…e83676cab61b60658429-on-r2.6

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac added a commit that referenced this pull request Oct 28, 2021
…e83676cab61b60658429-on-r2.5

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac added a commit that referenced this pull request Oct 28, 2021
…e83676cab61b60658429-on-r2.4

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac pushed a commit that referenced this pull request Oct 28, 2021
PiperOrigin-RevId: 406020083
Change-Id: I179a9a8fe548ed324fc97363e81a46be28aa19b8
mihaimaruseac added a commit that referenced this pull request Oct 28, 2021
Merge pull request #51733 from yongtang:46888-tf.math.segment_
nluehr added a commit to NVIDIA/tensorflow that referenced this pull request Mar 30, 2022
Along with db585eaa40c backports PR
tensorflow/tensorflow#51733.
liutongxuan pushed a commit to liutongxuan/DeepRec that referenced this pull request Jul 28, 2022
Along with db585eaa40c backports PR
tensorflow/tensorflow#51733.
liutongxuan pushed a commit to liutongxuan/DeepRec that referenced this pull request Aug 1, 2022
Along with db585eaa40c backports PR
tensorflow/tensorflow#51733.
liutongxuan pushed a commit to liutongxuan/DeepRec that referenced this pull request Aug 3, 2022
Along with db585eaa40c backports PR
tensorflow/tensorflow#51733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:ops OPs related issues prtype:bugfix PR to fix a bug size:S CL Change Size: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large

6 participants