[determinism] Add d9m-unimplemented exceptions to sparse/sparse matmul #50355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedwm
suggested changes
Jun 21, 2021
tensorflow/python/kernel_tests/sparse_tensor_dense_matmul_op_deterministic_test.py
Outdated
Show resolved
Hide resolved
reedwm
approved these changes
Jun 22, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
approved these changes
Jun 22, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This current PR is a follow-on to closed PR 47749 (Add GPU determinism for fp types in GPU SparseTensorDenseMatMul). This current PR adds and tests determinism-unimplemented exception-throwing for
tf.sparse.sparse_dense_matmulwhen is running on a GPU. This current PR also adds tests for the bit-exact reproducibility (determinism) oftf.sparse.sparse_dense_matmul(forward direction only, not gradients) when running a CPU.This PR is related to RFC: Enabling Determinism in TensorFlow. For status and history of GPU-determinism for this op, see here.
CC @reedwm, @sanjoy, @nluehr