[ROCm] Fix for ROCm CSB breakages - 210319 #47919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 1 The following commit breaks the following unit-tests on ROCm tensorflow@92e0315 ``` //tensorflow/compiler/xla/service/gpu/tests:gpu_infeed_test FAILED in 3 out of 3 in 1.8s //tensorflow/compiler/xla/tests:local_client_execute_test_gpu FAILED in 3 out of 3 in 13.7s //tensorflow/compiler/xla/tests:outfeed_in_nested_computation_test_gpu FAILED in 3 out of 3 in 2.0s //tensorflow/compiler/xla/tests:while_test_gpu FAILED in 3 out of 3 in 9.9s ``` The cause is that part of the changes were not enabled for ROCm, and this commit fixes that. ## 2 The following commit breaks the following unit-test on ROCm tensorflow#47772 ``` //tensorflow/python/kernel_tests:segment_reduction_ops_deterministic_test_gpu FAILED in 3 out of 3 in 5.3s ``` ROCm platform does not yet support complex datatype for the segment reduction ops, which is what leads to the failure. This commit modifies the testcase to skip testing the complex datatype on ROCm
cheshire
approved these changes
Mar 19, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
comp:gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1
The following commit breaks the following unit-tests on ROCm
92e0315
The cause is that part of the changes were not enabled for ROCm, and this commit fixes that.
2
The following commit breaks the following unit-test on ROCm
#47772
ROCm platform does not yet support complex datatype for the segment reduction ops, which is what leads to the failure.
This commit modifies the testcase to skip testing the complex datatype on ROCm
/cc @cheshire @chsigg