Skip to content

Conversation

@gunan
Copy link
Contributor

@gunan gunan commented Feb 25, 2019

No description provided.

@gunan gunan requested a review from aselle February 25, 2019 19:29
Copy link
Contributor

@aselle aselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gunan gunan merged commit 6612da8 into tensorflow:r1.13 Feb 25, 2019
@gunan gunan deleted the r1.13 branch February 25, 2019 20:37
@wookayin
Copy link
Contributor

wookayin commented Feb 25, 2019

Sorry for disturbing you guys, but just out of curiosity, what happened to 1.13.0? I found it: #26046.

@gunan
Copy link
Contributor Author

gunan commented Feb 25, 2019

Yes, I created the tag on the master branch by mistake.
Previously, when we overwrote tags, there were issues, so we decided to skip 1.13.0 and release 1.13.1

@stonebig
Copy link

stonebig commented Feb 26, 2019

will there be a Tensorflow-1.13.1 on pypi ? it's still Tensorflow-1.13.0rc2 there

copybara-service bot pushed a commit that referenced this pull request May 6, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#26101 from jreiffers:allow-bitcasts 6ce1446fd64a1c499d5bc3bbb7127debba1e010d
PiperOrigin-RevId: 755303558
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#26101 from jreiffers:allow-bitcasts 6ce1446fd64a1c499d5bc3bbb7127debba1e010d
PiperOrigin-RevId: 755303558
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#26101 from jreiffers:allow-bitcasts 6ce1446fd64a1c499d5bc3bbb7127debba1e010d
PiperOrigin-RevId: 755303558
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#26101 from jreiffers:allow-bitcasts 6ce1446fd64a1c499d5bc3bbb7127debba1e010d
PiperOrigin-RevId: 755303558
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

Reverts affe0dd

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#26101 from jreiffers:allow-bitcasts 6ce1446fd64a1c499d5bc3bbb7127debba1e010d
PiperOrigin-RevId: 755303558
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Imported from GitHub PR openxla/xla#26101

Both before and after the dynamic-(update-)slice.

This is in line with other copy fusions. I just missed this case previously.
Copybara import of the project:

--
9c5387ea4c099714972687c3c0b5b9b0e259f1fb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Allow bitcasts in dynamic memcpy fusions.

Both before and after the dynamic-(update-)slice.

--
8c1572960824217a8378a0406982670b6a13e923 by Johannes Reifferscheid <jreiffers@nvidia.com>:

More uniform bitcast handling.

--
6999c66814f4cb3e6d3db02661bb314a303ab72d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Clean up unused variable.

--
6ce1446fd64a1c499d5bc3bbb7127debba1e010d by Johannes Reifferscheid <jreiffers@nvidia.com>:

Move helpers to anonymous namespace.

Merging this change closes #26101

PiperOrigin-RevId: 755792283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants