Validate values sequence input in tf.stack (fix #125374) - #125386
Open
SparshGarg999 wants to merge 1 commit into
Open
Validate values sequence input in tf.stack (fix #125374)#125386SparshGarg999 wants to merge 1 commit into
SparshGarg999 wants to merge 1 commit into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125374
Context & Problem
tf.stackdocuments itsvaluesparameter as a sequence of tensors. When passed a singleTensorobject directly instead of a sequence, eager mode silently passed the input tensor through unchanged (no stacking performed), whereas XLA compilation (jit_compile=True) raised aTypeErrorfrom the underlyingPackop.Solution & Changes
tf.stackintensorflow/python/ops/array_ops.pyto ensure consistentTypeErrorexceptions are raised across eager, graph, and XLA execution modes whenvaluesis not a list or tuple of tensors.Testing & Verification
tf.stackinput validation with single tensor vs sequence inputs under eager execution and XLA (jit_compile=True).