fix(array_ops): align eager and compiled graph behavior for single tensor tf.stack - #125381
Open
SparshGarg999 wants to merge 2 commits into
Open
fix(array_ops): align eager and compiled graph behavior for single tensor tf.stack#125381SparshGarg999 wants to merge 2 commits into
SparshGarg999 wants to merge 2 commits into
Conversation
… and graph execution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies tensorflow/python/ops/array_ops_stack.py to wrap a single Tensor or CompositeTensor in a list when passed to tf.stack. The reviewer noted that the type check using isinstance does not account for tf.Variable objects (such as ResourceVariable), which are common tensor-like objects. They suggested using ops.is_tensor(values) instead to ensure robust handling of both Tensor and Variable objects.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125374
Description
Calling
tf.stackwith a single bareTensor(rather than a list or tuple of tensors) currently behaves inconsistently across execution modes. Under eager execution,tf.stacksilently returns the singleTensorunstacked, whereas underjit_compile=Trueor autoclustering, it raises aTypeErrorfrom the underlyingPackop.Fix
Updated
tf.stackintensorflow/python/ops/array_ops_stack.pyto check ifvaluesis an instance ofTensororCompositeTensorand normalize it into a list[values]prior to graph/op construction, ensuring consistent stacking behavior across both eager and compiled graph execution paths.