Fix confusion of clang-format/clang-tidy in contribution guidelines - #125361
Open
Flamefire wants to merge 1 commit into
Open
Fix confusion of clang-format/clang-tidy in contribution guidelines#125361Flamefire wants to merge 1 commit into
clang-format/clang-tidy in contribution guidelines#125361Flamefire wants to merge 1 commit into
Conversation
The example shows using `clang-format` but the sentences before talk about `clang-tidy`. From the related Python paragraph it can be inferred that clang-format is intended. Also remove the docker-like reference to an outdated Ubuntu and add `sudo` to `apt-get` for clarity
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the contributing guidelines in CONTRIBUTING.md to recommend using clang-format instead of clang-tidy for checking C/C++ changes, along with updating the corresponding installation command for Ubuntu. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example shows using
clang-formatbut the sentences before talk aboutclang-tidy. From the related Python paragraph it can be inferred that clang-format is intended.Also remove the docker-like reference to an outdated Ubuntu and add
sudotoapt-getfor clarity