webapp: add noscript message #4404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since TensorBoard is rendered entirely client-side with Angular and Polymer, the screen is entirely blank when JavaScript is disabled. This patch adds a simple “please enable JavaScript” `<noscript>` message. Fixes #4401. Test Plan: In both Chrome and Firefox, the message appears when JavaScript is disabled but not otherwise. It’s properly centered at wide window sizes and doesn’t create a horizontal scrollbar at narrow ones. Looks like: ![Screenshot of a blank page with a header “TensorBoard requires JavaScript”, followed by a message, “Please enable JavaScript and reload this page.” Both are rendered in Roboto, and appear to be centered in the screenshot.][ss] [ss]: https://user-images.githubusercontent.com/4317806/100648627-0b6d7b00-32f6-11eb-9781-68af70d7cb1f.png wchargin-branch: noscript-message wchargin-source: d0d821b92a6afc437a40b9c6bb439b4a6e70f7b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since TensorBoard is rendered entirely client-side with Angular and
Polymer, the screen is entirely blank when JavaScript is disabled. This
patch adds a simple “please enable JavaScript”
<noscript>message.Fixes #4401.
Test Plan:
In both Chrome and Firefox, the message appears when JavaScript is
disabled but not otherwise. It’s properly centered at wide window sizes
and doesn’t create a horizontal scrollbar at narrow ones. Looks like:
wchargin-branch: noscript-message