Skip to content

Conversation

@hfiller
Copy link
Contributor

@hfiller hfiller commented May 19, 2020

Update projector config to better handle multiple runs. If multiple runs are present, only one set of config/metadata needs to be present in the root directory, which will be used for any runs without config explicitly set.

@hfiller hfiller requested a review from nfelt May 19, 2020 20:02
@hfiller hfiller merged commit 12f6234 into master Jun 1, 2020
@stephanwlee stephanwlee deleted the hfiller-projector-config branch June 17, 2020 16:56
psybuzz added a commit that referenced this pull request Jul 16, 2020
…runs" (#3850)

This reverts commit 12f6234.

The changes in [1] allowed TensorBoard to use the root directory's
projector config and apply it to each subdirectory.

If the root dir's config specifies a "sprite" that does not exist in every
subdirectory, it causes the Projector frontend to hang when loading a run.
See #3840 for details on
the issue.

Confirmed that this fixes the issue by running TB on a directory with:

- ./projector_config.pbtxt
```
embeddings {
  tensor_name: "EMNIST_Letters:0"
  metadata_path: "metadata.tsv"
  sprite {
    image_path: "sprite.png"
    single_image_dim: 28
    single_image_dim: 28
  }
}
```
- alongside a subdirectory `profile_demo_new` that contains a `.profile-empty` event file but no `sprite.png` file

[1] #3653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants