ui: fix run selector toggle all with many items #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
approved these changes
Sep 11, 2019
Contributor
wchargin
left a comment
wchargin
left a comment
There was a problem hiding this comment.
Nice! Confirmed that the toggle state works correctly from a directory
with 4 runs (default on, toggles off with one click) and a directory
with 188 runs (default off, toggles on with one click).
psybuzz
changed the title
Contributor
Author
|
Thanks for the review! Adding Stephan fyi, and landing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run selector has a toggle all runs button. Before, toggleAll()'s intent is to toggle everything off when the user hasn't interacted with the list and the list is short (<40, everything selected by default). This logic was broken in [1], which renamed "maxRunsToEnableByDefault" to "maxNamesToEnableByDefault", except for one callsite (causing issue #2614).
This PR fixes the issue and simplifies toggleAll() to rely on "this.outSelected", which already represents the computed selected state.
[1] aacd5cb