-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support undefined number of data points in the mesh. #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stephanwlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the JavaScript reviews: I can send you a pull request if you think that helps.
|
+reviewer: wchargin for Python readability. |
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review for python
Improving readability and perf
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to maintain data compatibility.
|
FYI, updated SHA for TF Graphics-hosted files, so you can test the whole thing if needed. Please let me know if there is anything else is needed to merge the change. |
stephanwlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE and most changes LGTM. I will let William finish review the Python part.
Adds support of undefined (None) number of vertices/faces/colors in the mesh.
How to test:
Run demo app and then launch tensorboard - observe mesh being rendered.
Also this PR changes the way we load data - from now on, every step is considered as unique data point and should be requested separately from the server (similar to image plugin). Please note that each mesh/step will produce 1 to 3 requests based on what data was passed into the summary (i.e. if there are no colors specified, then it will request only vertices and faces).
This PR depends on some TF-Graphics changes (I'll update it with new SHA once changes merged).