Fixed tagFilterer to correctly bootstrap and work #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Oct 10, 2018
Contributor
There was a problem hiding this comment.
I'd call this _computeTagFilter() for consistency with the other computed property methods, even though this one doesn't really do meaningful computation. It's also pretty weird for a method named "setXX" to actually have no direct side effects (and which looks like a vanilla getter).
tf-tag-filterer, correctly, defined its property `tag-filter` as readOnly and this broke the data connection between `paper-input`. Between the paper-input and the filterer, there should be a two-way binding of its value whereas all the consumers of the tf-tag-filterer should only read from the component. Now, using the private property, `_tagFilter`, we establish the two-way binding while the public property is only used to publish the change. Note: bug was introduced over tensorflow#1483, tensorflow#1475, and tensorflow#1493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf-tag-filterer, correctly, defined its property
tag-filterasreadOnly and this broke the data connection between
paper-input.Between the paper-input and the filterer, there should be a
two-way binding of its value whereas all the consumers of the
tf-tag-filterer should only read from the component.
Now, using the private property,
_tagFilter, we establish the two-waybinding while the public property is only used to publish the change.
Note: bug was introduced over #1483, #1475, and #1493.