Skip to content

Expose tagFilter persistence to hash #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 1 commit into from
Oct 2, 2018
Merged

Expose tagFilter persistence to hash #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorboard/components/tf_categorization_utils/tf-tag-filterer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@
type: String,
notify: true,
value: tf_storage.getStringInitializer('tagFilter',
{defaultValue: '', useLocalStorage: true}),
{defaultValue: '', useLocalStorage: false}),
observer: '_tagFilterObserver',
},
},

_tagFilterObserver: tf_storage.getStringObserver(
'tagFilter', {defaultValue: '', useLocalStorage: true}),
'tagFilter', {defaultValue: '', useLocalStorage: false}),
});
</script>
</dom-module>
3 changes: 0 additions & 3 deletions tensorboard/plugins/audio/tf_audio_dashboard/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ tf_web_library(
"//tensorboard/components/tf_paginated_view",
"//tensorboard/components/tf_runs_selector",
"//tensorboard/components/tf_tensorboard:registry",
"@org_polymer_iron_icon",
"@org_polymer_paper_icon_button",
"@org_polymer_paper_input",
"@org_polymer_paper_slider",
"@org_polymer_paper_spinner",
"@org_polymer_paper_styles",
Expand Down
17 changes: 3 additions & 14 deletions tensorboard/plugins/audio/tf_audio_dashboard/tf-audio-dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@
limitations under the License.
-->

<link rel="import" href="../iron-icon/iron-icon.html">
<link rel="import" href="../paper-input/paper-input.html">
<link rel="import" href="../polymer/polymer.html">
<link rel="import" href="../tf-backend/tf-backend.html">
<link rel="import" href="../tf-categorization-utils/tf-categorization-utils.html">
<link rel="import" href="../tf-categorization-utils/tf-category-pane.html">
<link rel="import" href="../tf-categorization-utils/tf-tag-filterer.html">
<link rel="import" href="../tf-dashboard-common/dashboard-style.html">
<link rel="import" href="../tf-dashboard-common/tf-dashboard-layout.html">
<link rel="import" href="../tf-paginated-view/tf-paginated-view.html">
Expand Down Expand Up @@ -63,14 +62,7 @@ <h3>No audio data was found.</h3>
</div>
</template>
<template is="dom-if" if="[[!_dataNotFound]]">
<paper-input
no-label-float
label="Filter tags (regular expressions supported)"
value="{{_tagFilter}}"
class="search-input"
>
<iron-icon prefix icon="search"></iron-icon>
</paper-input>
<tf-tag-filterer tag-filter="{{_tagFilter}}"></tf-tag-filterer>
<template is="dom-repeat" items="[[_categories]]" as="category">
<tf-category-pane category="[[category]]" opened="[[_shouldOpen(index)]]">
<tf-paginated-view
Expand Down Expand Up @@ -117,10 +109,7 @@ <h3>No audio data was found.</h3>
_runToTagInfo: Object,
_dataNotFound: Boolean,

_tagFilter: {
type: String, // upward bound from paper-input
value: '',
},
_tagFilter: String,
_categories: {
type: Array,
computed:
Expand Down
5 changes: 1 addition & 4 deletions tensorboard/plugins/scalar/tf_scalar_dashboard/tf-scalar-dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,7 @@ <h3>No scalar data was found.</h3>
},
_runToTagInfo: Object,
_dataNotFound: Boolean,
_tagFilter: {
type: String,
value: '',
},
_tagFilter: String,
// Categories must only be computed after _dataNotFound is found to be
// true and then polymer DOM templating responds to that finding. We
// thus use this property to guard when categories are computed.
Expand Down