Fix a bug that pie chart in input_pipeline_analyzer is missing #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Jun 26, 2018
Contributor
|
I think this test failure is unrelated, but if you don't mind waiting a day or two I'll see if we can fix that first so this passes Travis? |
Contributor
Author
|
Sure, I can wait. Thanks @nfelt |
qiuminxu
force-pushed
the
fix_pie_chart_new
branch
from
0b067c6 to
15e5604
Compare
…ing. Fix the 'node' not found error. Need to use dom-if to clear hidden components.
qiuminxu
force-pushed
the
fix_pie_chart_new
branch
from
0a5467a to
885ce85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input Pipeline Analyzer:
The pie chart in input_pipeline_analyzer is occasionally missing due to two reasons:
(1) When -0.00 is present in the input JSON.
(2) Try to render the pie chart when DOM is not ready.
Fix these two issues and also refactored the code for better performance.
Overview Page:
Fix the 'node' not found error. Need to use dom-if so that isn't a hidden line chart from another RUN.