[Debugger Plugin] Fix wrapper name for keras snippet #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Apr 3, 2018
|
|
||
| keras.backend.set_session( | ||
| tf_debug.LocalCLIDebugWrapperSession(tf.Session()), "[[_host]]:[[_port]]") | ||
| tf_debug.TensorBoardDebugWrapperSession(tf.Session()), "[[_host]]:[[_port]]") |
Contributor
There was a problem hiding this comment.
I think the parens need to be adjusted here, right now the "host:port" string is being passed to set_session() but it should actually be the second arg to TensorBoardDebugWrapperSession
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching that!
nfelt
pushed a commit
to nfelt/tensorboard
that referenced
this pull request
Apr 24, 2018
* [Debugger Plugin] Fix wrapper name for keras snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1097