Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.17
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 28 files changed
  • 9 contributors

Commits on Jun 7, 2024

  1. Update TF compat protos.

    arcra committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1438f6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    047a9c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d53d31 View commit details
    Browse the repository at this point in the history
  4. TensorBoard 2.17.0

    arcra committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9408e08 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Bump braces from 3.0.2 to 3.0.3 (#6868)

    Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/micromatch/braces/commit/74b2db2938fad48a2ea54a9c8bf27a37a62c350d"><code>74b2db2</code></a>
    3.0.3</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/88f1429a0f47e1dd3813de35211fc97ffda27f9e"><code>88f1429</code></a>
    update eslint. lint, fix unit tests.</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/415d660c3002d1ab7e63dbf490c9851da80596ff"><code>415d660</code></a>
    Snyk js braces 6838727 (<a
    href="https://redirect.github.com/micromatch/braces/issues/40">#40</a>)</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/190510f79db1adf21d92798b0bb6fccc1f72c9d6"><code>190510f</code></a>
    fix tests, skip 1 test in test/braces.expand</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/716eb9f12d820b145a831ad678618731927e8856"><code>716eb9f</code></a>
    readme bump</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/a5851e57f45c3431a94d83fc565754bc10f5bbc3"><code>a5851e5</code></a>
    Merge pull request <a
    href="https://redirect.github.com/micromatch/braces/issues/37">#37</a>
    from coderaiser/fix/vulnerability</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/2092bd1fb108d2c59bd62e243b70ad98db961538"><code>2092bd1</code></a>
    feature: braces: add maxSymbols (<a
    href="https://github.com/micromatch/braces/issues/">https://github.com/micromatch/braces/issues/</a>...</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/9f5b4cf47329351bcb64287223ffb6ecc9a5e6d3"><code>9f5b4cf</code></a>
    fix: vulnerability (<a
    href="https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727">https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727</a>)</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/98414f9f1fabe021736e26836d8306d5de747e0d"><code>98414f9</code></a>
    remove funding file</li>
    <li><a
    href="https://github.com/micromatch/braces/commit/665ab5d561c017a38ba7aafd92cc6655b91d8c14"><code>665ab5d</code></a>
    update keepEscaping doc (<a
    href="https://redirect.github.com/micromatch/braces/issues/27">#27</a>)</li>
    <li>Additional commits viewable in <a
    href="https://github.com/micromatch/braces/compare/3.0.2...3.0.3">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=braces&package-manager=npm_and_yarn&previous-version=3.0.2&new-version=3.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f6fde73 View commit details
    Browse the repository at this point in the history
  2. Update usage of numpy to reflect numpy 2.0 changes (#6871)

    ## Motivation for features / changes
    Nightlies are failing due to new numpy release(one example:
    https://github.com/tensorflow/tensorboard/actions/runs/9546526095/job/26309613783)
    
    ## Technical description of changes
    The new numpy replaced np.string_ with np.bytes_ and np.unicode_ with
    np.str_
    
    ## Screenshots of UI changes (or N/A)
    
    ## Detailed steps to verify changes work correctly (as executed by you)
    I ran tests that were failing and they passed.
    
    ## Alternate designs / implementations considered (or N/A)
    Locking numpy version < 2 was considered. However, this will eventually
    get us very out of date and should be avoided.
    
    ---------
    
    Co-authored-by: James Hollyer <jameshollyer@google.com>
    2 people authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3dbfc22 View commit details
    Browse the repository at this point in the history
  3. Fix stacking of notification dot (#6875)

    An upcoming change in Angular Material
    (angular/components#29291) changes the `z-index`
    of icons which ended up putting it behind the notification dot.
    
    This change adds an explicit `z-index` to the dot to ensure that it's on
    top of the icon.
    crisbeto authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7065efa View commit details
    Browse the repository at this point in the history
  4. Bump socket.io from 4.5.3 to 4.7.5 (#6870)

    Bumps [socket.io](https://github.com/socketio/socket.io) from 4.5.3 to
    4.7.5.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a
    href="https://github.com/socketio/socket.io/releases">socket.io's
    releases</a>.</em></p>
    <blockquote>
    <h2>4.7.5</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li>close the adapters when the server is closed (<a
    href="https://github.com/socketio/socket.io/commit/bf64870957e626a73e0544716a1a41a4ba5093bb">bf64870</a>)</li>
    <li>remove duplicate pipeline when serving bundle (<a
    href="https://github.com/socketio/socket.io/commit/e426f3e8e1bfea5720c32d30a3663303200ee6ad">e426f3e</a>)</li>
    </ul>
    <h4>Links</h4>
    <ul>
    <li>Diff: <a
    href="https://github.com/socketio/socket.io/compare/4.7.4...4.7.5">https://github.com/socketio/socket.io/compare/4.7.4...4.7.5</a></li>
    <li>Client release: <a
    href="https://github.com/socketio/socket.io-client/releases/tag/4.7.5">4.7.5</a></li>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2>4.7.4</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li><strong>typings:</strong> calling io.emit with no arguments
    incorrectly errored (<a
    href="https://github.com/socketio/socket.io/commit/cb6d2e02aa7ec03c2de1817d35cffa1128b107ef">cb6d2e0</a>),
    closes <a
    href="https://redirect.github.com/socketio/socket.io/issues/4914">#4914</a></li>
    </ul>
    <h4>Links</h4>
    <ul>
    <li>Diff: <a
    href="https://github.com/socketio/socket.io/compare/4.7.3...4.7.4">https://github.com/socketio/socket.io/compare/4.7.3...4.7.4</a></li>
    <li>Client release: <a
    href="https://github.com/socketio/socket.io-client/releases/tag/4.7.4">4.7.4</a></li>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2>4.7.3</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li>return the first response when broadcasting to a single socket (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4878">#4878</a>)
    (<a
    href="https://github.com/socketio/socket.io/commit/df8e70f79822e3887b4f21ca718af8a53bbda2c4">df8e70f</a>)</li>
    <li><strong>typings:</strong> allow to bind to a non-secure Http2Server
    (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4853">#4853</a>)
    (<a
    href="https://github.com/socketio/socket.io/commit/8c9ebc30e5452ff9381af5d79f547394fa55633c">8c9ebc3</a>)</li>
    </ul>
    <h4>Links</h4>
    <ul>
    <li>Diff: <a
    href="https://github.com/socketio/socket.io/compare/4.7.2...4.7.3">https://github.com/socketio/socket.io/compare/4.7.2...4.7.3</a></li>
    <li>Client release: <a
    href="https://github.com/socketio/socket.io-client/releases/tag/4.7.3">4.7.3</a></li>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2>4.7.2</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li>clean up child namespace when client is rejected in middleware (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4773">#4773</a>)
    (<a
    href="https://github.com/socketio/socket.io/commit/0731c0d2f497d5cce596ea1ec32a67c08bcccbcd">0731c0d</a>)</li>
    <li><strong>webtransport:</strong> properly handle WebTransport-only
    connections (<a
    href="https://github.com/socketio/socket.io/commit/3468a197afe87e65eb0d779fabd347fe683013ab">3468a19</a>)</li>
    <li><strong>webtransport:</strong> add proper framing (<a
    href="https://github.com/socketio/engine.io/commit/a306db09e8ddb367c7d62f45fec920f979580b7c">a306db0</a>)</li>
    </ul>
    <h4>Links</h4>
    <!-- raw HTML omitted -->
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a
    href="https://github.com/socketio/socket.io/blob/main/CHANGELOG.md">socket.io's
    changelog</a>.</em></p>
    <blockquote>
    <h2><a
    href="https://github.com/socketio/socket.io/compare/4.7.4...4.7.5">4.7.5</a>
    (2024-03-14)</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li>close the adapters when the server is closed (<a
    href="https://github.com/socketio/socket.io/commit/bf64870957e626a73e0544716a1a41a4ba5093bb">bf64870</a>)</li>
    <li>remove duplicate pipeline when serving bundle (<a
    href="https://github.com/socketio/socket.io/commit/e426f3e8e1bfea5720c32d30a3663303200ee6ad">e426f3e</a>)</li>
    </ul>
    <h3>Dependencies</h3>
    <ul>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2><a
    href="https://github.com/socketio/socket.io/compare/4.7.3...4.7.4">4.7.4</a>
    (2024-01-12)</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li><strong>typings:</strong> calling io.emit with no arguments
    incorrectly errored (<a
    href="https://github.com/socketio/socket.io/commit/cb6d2e02aa7ec03c2de1817d35cffa1128b107ef">cb6d2e0</a>),
    closes <a
    href="https://redirect.github.com/socketio/socket.io/issues/4914">#4914</a></li>
    </ul>
    <h3>Dependencies</h3>
    <ul>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2><a
    href="https://github.com/socketio/socket.io/compare/4.7.2...4.7.3">4.7.3</a>
    (2024-01-03)</h2>
    <h3>Bug Fixes</h3>
    <ul>
    <li>return the first response when broadcasting to a single socket (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4878">#4878</a>)
    (<a
    href="https://github.com/socketio/socket.io/commit/df8e70f79822e3887b4f21ca718af8a53bbda2c4">df8e70f</a>)</li>
    <li><strong>typings:</strong> allow to bind to a non-secure Http2Server
    (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4853">#4853</a>)
    (<a
    href="https://github.com/socketio/socket.io/commit/8c9ebc30e5452ff9381af5d79f547394fa55633c">8c9ebc3</a>)</li>
    </ul>
    <h3>Dependencies</h3>
    <ul>
    <li><a
    href="https://github.com/socketio/engine.io/releases/tag/6.5.2"><code>engine.io@~6.5.2</code></a>
    (no change)</li>
    <li><a
    href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
    (no change)</li>
    </ul>
    <h2><a
    href="https://github.com/socketio/socket.io/compare/4.7.1...4.7.2">4.7.2</a>
    (2023-08-02)</h2>
    <!-- raw HTML omitted -->
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/socketio/socket.io/commit/50176812a1f815b779cf8936996b06e559122620"><code>5017681</code></a>
    chore(release): 4.7.5</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/bf64870957e626a73e0544716a1a41a4ba5093bb"><code>bf64870</code></a>
    fix: close the adapters when the server is closed</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/748e18c22eeefceb4030c8f8e5e9e9c342b05982"><code>748e18c</code></a>
    ci: test with older TypeScript version</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/b9ce6a25d1f99368fe21fdc0308213fa1831e450"><code>b9ce6a2</code></a>
    refactor: create specific adapter for parent namespaces (<a
    href="https://redirect.github.com/socketio/socket.io/issues/4950">#4950</a>)</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/54dabe5bffeb705fd006729725dd2fa194f70ecf"><code>54dabe5</code></a>
    ci: upgrade to actions/checkout@4 and actions/setup-node@4</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/e426f3e8e1bfea5720c32d30a3663303200ee6ad"><code>e426f3e</code></a>
    fix: remove duplicate pipeline when serving bundle</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/e36062ca2df0b1a4adcf986bafc3fd92675d3896"><code>e36062c</code></a>
    docs: update the webtransport example</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/0bbe8aec77a0ed5576d8e4fa7379ab1f1a6fdb05"><code>0bbe8ae</code></a>
    docs: only execute the passport middleware once</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/914a8bd2b97f559a666ede08df8610cfe05e9cda"><code>914a8bd</code></a>
    docs: add example with JWT</li>
    <li><a
    href="https://github.com/socketio/socket.io/commit/d943c3e0b0b6af1df544a6d26e09dbc8243f4d90"><code>d943c3e</code></a>
    docs: update the Passport.js example</li>
    <li>Additional commits viewable in <a
    href="https://github.com/socketio/socket.io/compare/4.5.3...4.7.5">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.5.3&new-version=4.7.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the
    [Security Alerts
    page](https://github.com/tensorflow/tensorboard/network/alerts).
    
    </details>
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    37b5556 View commit details
    Browse the repository at this point in the history
  5. 🐛 ⚙️ Fix settings dialog styling regression (#6885)

    ## Motivation for features / changes
    When we migrated all the MDC components a year or so ago we missed the
    size of the fields in the settings dialog changing. This should restore
    the original intention there.
    
    ## Screenshots of UI changes (or N/A)
    
    Before:
    
    ![image](https://github.com/user-attachments/assets/e7cb590c-78bd-474f-89da-cef2a74d1a91)
    
    After:
    
    ![image](https://github.com/user-attachments/assets/ff12fa0c-27ac-48f8-9817-25c7b5fc0fc8)
    rileyajones authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ddbe091 View commit details
    Browse the repository at this point in the history
  6. LSC — Explicitly mark AOT incompatible targets via 'jit:true' (#6886)

    ## Motivation for features / changes
    
    This PR is for the LSC that will add `jit: true` to all `@Directive`,
    `@Component` and `@NgModule` classes that are not AOT compatible.
    
    Commonly in Google3, TypeScript test files are part of a `ts_library` or
    a `ng_module w/ testonly=True`. These targets simply run the TypeScript
    compiler from Microsoft, without any specific Angular processing. This
    allows code to exist that isn't necessarily compatible with Angular's
    compiler that strictly checks e.g. components
    
    This LSC adds `jit: true` to those components to clearly indicate that
    those components are not processed by the Angular compiler. This is a
    no-op because the Angular compiler doesn't even run on these files (as
    said above). In the future, we would like to change this, and need clear
    indication of what is incompatible or not. This is what the `jit: true`
    flag does. The `jit: true` flag basically tells the Angular compiler to
    ignore these components, so that their behavior is unchanged and
    everything continues to work like before.
    qihach64 authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f6fdedf View commit details
    Browse the repository at this point in the history
  7. Relax protobuf<5.0.0 restriction (#6888)

    Instead of restricting `protobuf<5.0.0` due to the removal to
    `including_default_value_fields` kwarg in `json_format.MessageToJson`
    (replaced by `always_print_fields_with_nopresence`), we can instead
    detect the currently installed protobuf version and use the appropriate
    kwarg.
    
    Contributes to #6808 and should resolve #6887.
    groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9e6d7e8 View commit details
    Browse the repository at this point in the history
  8. Custom modal aux click (#6891)

    ## Motivation for features / changes
    On some browsers, the [custom modal
    close](https://github.com/tensorflow/tensorboard/blob/0627ad5480b309a5f3f69f39e52670496c2e5863/tensorboard/webapp/widgets/custom_modal/custom_modal.ts#L116)
    logic will be triggered immediately after releasing the right click
    button, which causes the modal to be closed as soon as it is opened.
    
    ## Technical description of changes
    The modal close event handler will ignore the `auxclick` (right click)
    mouseup event. Modals can still be closed with left clicks and the
    `contextmenu` event.
    
    ## Screenshots of UI changes (or N/A)
    Status quo:
    ![image](https://github.com/user-attachments/assets/5b4c0c8f-4878-4cbe-a46a-cd425c188061)
    hoonji authored and groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6880188 View commit details
    Browse the repository at this point in the history
  9. Ensure protobuf is installed internally (#6892)

    Required to get internal build passing
    groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6d69133 View commit details
    Browse the repository at this point in the history
  10. Internal sync fix (#6893)

    Update build rules to properly match expected sync format.
    groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6bc92af View commit details
    Browse the repository at this point in the history
  11. Avoid discrepancies due to importlib.metadata.version not working i… (

    #6894)
    
    …nternally
    
    If `protobuf` isn't installed locally, the underlying call to
    `json_format.MessageToJson` will still fail.
    groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1e22fc3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a3666ef View commit details
    Browse the repository at this point in the history
  13. TensorBoard 2.17.1

    groszewn committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3303a01 View commit details
    Browse the repository at this point in the history
Loading