Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.9.0
Choose a base ref
...
head repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.9
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 8, 2022

  1. Force protobuf dependency < 3.20. (#5726) 

    The latest protobuf release is not backwards compatible with TensorFlow's protos and our copies of those protos in tensorboard/compat/proto . We knew this change was coming so, fortunately, TF had already fixed their dependencies to force a compatible version of protobuf. However, we also have to update our own requirements.txt to force the same version of protobuf, to unbreak the build when TensorFlow is not installed.

Googlers, see: http://b/182876485.
See: protocolbuffers/protobuf#9954 (comment)
See: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/tools/pip_package/setup.py?q=protobuf
    @bmd3k
    bmd3k committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a92eabd View commit details
    Browse the repository at this point in the history

  2. Recognize text/javascript as valid js mimetype for caching purposes (#… 

    …5746)

Recently the test core_plugin_test.py::test_js_cache began to fail in some environments with the following error:

```
... core_plugin_test.py", line 196, in test_js_cache
self.assertEqual(
AssertionError: 
- private, max-age=86400
+ no-cache, must-revalidate
```

The root cause is that these systems have now been configured to return 'text/javascript' as the mimetype for js files, where they were previously returning 'application/javascript'. This means the 'Cache-Control' header was not set by this line:

https://cs.opensource.google/tensorflow/tensorboard/+/master:tensorboard/plugins/core/core_plugin.py;l=137;drc=c061b659f50cde9dd9da5aa906ecb682ecdc68d4

```
        expires = (
            JS_CACHE_EXPIRATION_IN_SECS
            if request.args.get("_file_hash")
            and mimetype == "application/javascript"
            else 0
        )
```

After further investigation (thanks @nfelt!) we determined that the change in mimetype is likely intentional after the recent publishing of RFC 9239 (https://www.rfc-editor.org/rfc/rfc9239), where 'text/javascript' becomes the standard mimetype for js files.

We decided, therefore, to change the Cache-Control-setting logic to also recognize 'text/javascript'.

Note, in practice, the change in mimetype had no impact on running tensorboards thanks to the logic added in #3128, which always ensures ".js" is mapped to mimetype "application/javascript" but does it at a higher level (ie outside either core plugin or the http utils).
    @bmd3k
    bmd3k committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    92664a2 View commit details
    Browse the repository at this point in the history

  3. Add 2.9.1 relnotes to RELEASE.md

    @bmd3k
    bmd3k committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e396343 View commit details
    Browse the repository at this point in the history

  4. TensorBoard 2.9.1

    @bmd3k
    bmd3k committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ea1c620 View commit details
    Browse the repository at this point in the history
Loading