Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.10.0
Choose a base ref
...
head repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.10
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Sep 22, 2022

  1. projector: Fix esbuild-bundled projector. (#5944) 

    The change to use the esbuild bundler (#5829) broke the projector plugin (#5924).

The root cause is in the 'numeric' library, which we use for calculating the PCA. The library requires that the symbol 'numeric' is available in the global scope when its operations are executed by other modules. See, for example, how the definition of some of its operations refer to the string 'numeric' in the Function definition, unmodifiable by the
bundler/minification code:

https://github.com/sloisel/numeric/blob/656fa1254be540f428710738ca9c1539625777f1/src/numeric.js#L696

The esbuild bundler does not keep 'numeric' in global scope and instead renames it as part of bundling/minification. We work around this by manually adding it to global scope.

We introduce the wrapper tensorboard/webapp/third_party/numeric.ts to add 'numeric' to the global scope and require that tensorboard code import that wrapper rather than importing numeric directly. We add a CI check to ensure that numeric is not imported directly.
    @bmd3k
    bmd3k committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    229db27 View commit details
    Browse the repository at this point in the history

  2. Add 2.10.1 relnotes to RELEASE.md

    @bmd3k
    bmd3k committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    800bd8c View commit details
    Browse the repository at this point in the history

  3. TensorBoard 2.10.1

    @bmd3k
    bmd3k committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a74c10d View commit details
    Browse the repository at this point in the history
Loading