Adding a hook for loading TF IO native libraries#468
Merged
karllessard merged 4 commits intotensorflow:masterfrom Aug 25, 2022
Merged
Adding a hook for loading TF IO native libraries#468karllessard merged 4 commits intotensorflow:masterfrom
karllessard merged 4 commits intotensorflow:masterfrom
Conversation
karllessard
previously approved these changes
Aug 23, 2022
Collaborator
karllessard
left a comment
karllessard
left a comment
There was a problem hiding this comment.
Approved but there is a small typo in the comments, feel free to merge it right away after fixing it
| } | ||
|
|
||
| /** | ||
| * Loads the filesystem plugin from fielname and registers all the filesystems it supports. |
Fixing the javadoc typo.
Because it doesn't report all the errors at once.
karllessard
approved these changes
Aug 25, 2022
Craigacp
added a commit
to Craigacp/tensorflow-java
that referenced
this pull request
Sep 16, 2022
karllessard
pushed a commit
to karllessard/tensorflow-java
that referenced
this pull request
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the C API method to load in a TF IO filesystem plugin. We can't test it without adding a bunch of binaries to the build, but it seems to load TF IO 2.9 without incident. I checked it by loading
<python-3.8-venv>/lib/python3.8/site-packages/tensorflow_io/python/ops/libtensorflow_io_plugins.so.This will help users with issues like #429, though they'll still need to download and unpack TF IO separately.