Redo Framework Ops based on the current version of Master.#342
Merged
karllessard merged 1 commit intotensorflow:masterfrom Jun 22, 2021
Merged
Redo Framework Ops based on the current version of Master.#342karllessard merged 1 commit intotensorflow:masterfrom
karllessard merged 1 commit intotensorflow:masterfrom
Conversation
karllessard
reviewed
Jun 22, 2021
| // Plugin should implement TF_InitKernel to register kernels. This function | ||
| // should register all kernels in a plugin. | ||
| public static native void TF_InitKernel(); | ||
|
|
Collaborator
There was a problem hiding this comment.
Note that I know where this change comes from :) I'm skipping this C API endpoint that was causing trouble on TF2.5 but I forgot to commit the updated generated bindings so let's keep it here
karllessard
approved these changes
Jun 22, 2021
Collaborator
karllessard
left a comment
karllessard
left a comment
There was a problem hiding this comment.
Looks good @JimClarke5 , thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reopen of #255 with a new branch using the latest master, as the old PR was way out of sync with the current master.
Added org.tensoflow.framwork.op.FrameworkOps to tensorflow-frameworks.
For now, these are not generated, but hard coded.
These are higher level ops that may invoke core ops. Higher level Ops may perform the
operation solely in the TensorFlow framework or do preprocessing of the Operands before invoking
a core level Op.
As part or this PR,tf.nn.raw generated package was removed and those ops are now generated directly into org.tensorflow.op.nn undertensorflow-core-api.
org.tensorflow.op.NnOps uses the core (formerly raw) ops for
SoftmaxCrossEntropyWithLogits and SparseSoftmaxCrossEntropyWithLogits.
FrameworkOps now contains the high level ops, sigmoidCrossEntropyWithLogits, softmaxCrossEntropyWithLogits, and sparseSoftmaxCrossEntropyWithLogits.
Also I moved SetsOps to org.tensorflow.framwork.op and l2Normalize to org.tensorflow.framwork.op.MathOps.
There are more framework ops when layers are checked in.
The easiest way to use it, for example is:
FrameworkOps fops = FrameworkOps.create(tf);
Operand result = fops.math.l2Normalize(tLabels, axis);
...
Operand diffResult = fops.sets.difference(weightsShape2D, validDims);