Fetch resource variable fix#276
Merged
karllessard merged 3 commits intotensorflow:masterfrom Apr 6, 2021
Merged
Conversation
karllessard
approved these changes
Apr 6, 2021
Contributor
|
Odd, I ran them locally just fine. Something may have been cached somewhere, but I'm pretty sure I cleaned first. It's possible my Python tensorflow version is different, but I wouldn't think that would matter. |
Collaborator
Author
|
The TF function code barfed on it because it didn't have any inputs. I'm not sure what it actually wrote out, but the TF native library did not like it. Maybe you've got an older version of Python tf which does something different? I tried it on 2.4.1 and it did not like the protobuf that was there. |
Contributor
|
Yeah, I've got 2.3.1 in Python, but the Java library is still using 2.4.1. Odd, but whatever, it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added in #261 was using a malformed protobuf as TF functions have to have at least one input. This caused the test to always fail. This PR fixes the python generation function, along with the protobuf file and the test itself. The python file was slightly reformatted to make it a little more PEP 8 friendly.
I also fixed a few small Javadoc issues in the hand written code of tensorflow-core-api, presumably the generated ones will be fixed by the PR that rewrites that.
cc @rnett