Generic cleanup Metrics and Losses#204
Conversation
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
…when I build it reverses these 2 from master's version.
…er for predictions instead of <T>.
|
Hi @JimClarke5 , there are some javadoc issues in this PR, please take a look: https://github.com/tensorflow/java/pull/204/checks?check_run_id=1825661890 |
|
BTW, do you have any clue why the javadoc has been reformatted? It looks like it was already conform before, I don't know why your IDE plugin would reformat these, can you please just double-check that you use your original settings? |
|
@karllessard I fixed all the JavaDoc issues under |
...-framework/src/main/java/org/tensorflow/framework/metrics/SparseCategoricalCrossentropy.java
Outdated
Show resolved
Hide resolved
karllessard
left a comment
karllessard
left a comment
There was a problem hiding this comment.
Great work @JimClarke5 , that simplifies really a lot some of the APIs. I just left a really-unimportant comment about something that looks like a trailing character, please confirm and/or fix and we are good to merge
|
Ok nevermind, I've remove the trailing character directly from your branch, this is now ready to merge, thanks! |
2 participants
This PR Is a reissue of the Generic Cleanup PR #203, removing commits in the branch that are already in
master.This PR effects both
lossesandmetrics.This PR cleans up generic parameters to cut down on the number of unique parameters to at most 1 where possible.
For example:
public abstract class Metric<U extends TNumber, T extends TNumber> {becomes
public abstract class Metric<T extends TNumber> {and
Changes to: